commit | 3a0f628313c824528df1d82b4577922e5e52e6e9 | [log] [tgz] |
---|---|---|
author | Sergio Villar Senin <svillar@igalia.com> | Thu Feb 07 10:59:06 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Feb 07 10:59:06 2019 |
tree | de5b617fbd48b99f0638f3d3129f882b89c1e457 | |
parent | 49587f4a0a2dd0755c7a344fcaf787409506f561 [diff] |
Stop listening for OnRefreshTokensLoaded() in FamilyInfoFetcher In crrev.com/c/1454618 FamilyInfoFetcher was migrated to use PrimaryAccountAccessTokenFetcher. However the code is still observing IdentityManager for the OnRefreshTokensLoaded() notification. It turns out that it is not very useful to listen to that as it's really unreliable. The reason is that at the time StartFetching gets called, OnRefreshTokensLoaded might or might not have happened already. If it has *not* already happened, then we'll report an error to the client. But if it *has* already happened, then we'll just end up waiting forever anyway. And there's not even a way for the client to know. Bug: 920965 Change-Id: I49b8741bfe438855bdf9c74c1a52528bba3baa79 Reviewed-on: https://chromium-review.googlesource.com/c/1454959 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629928}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .