Google Git
Sign in
chromium / chromium / src / 3bc8c5e3350b157512d58f4729e0ea44b3581618
commit3bc8c5e3350b157512d58f4729e0ea44b3581618[log] [tgz]
authorNick Diego Yamane <nickdiego@igalia.com>Thu Oct 14 02:41:10 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 14 02:41:10 2021
treed908109c6e08acd4d03f5d293e75379bd4056a1f
parent826c2299ab4cc20d3035fd1ab0f8c29ad3f549cc [diff]
wayland: disregard screen position when setting beforeunload dialog bounds

The dialog intended to confirm that the user wants to unload a page that
contains dirty form input items might get misplaced or do not show up at
all, when the host browser window is positioned in a non-primary display
(in extended displays mode). The issue happens because the bounds
calculation code in //components/constrained_window assumes that global
screen coordinates are supported by the underlying platform, which is
not true for Wayland, where popup positioning is done relatively to
its parent surface, for example.

This fixes it by avoiding such screen-related position calculation if
the Ozone platform does not support it, which required a new Ozone
platform property to be added.

[1] https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload

R=msw@chromium.org, rjkroege@chromium.org

 - With 2 side-by-side displays connected
 - Open, for example, crbug.com/1251750
 - Type some chars in comment text input item and try to close the tab
 - Verify "Changes you made may not be saved" dialog appears correctly

Bug: 1251750
Test: 
Change-Id: I2b49e2de936fa34b94aab7bd41a51547eaefc1ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220417
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931353}
5 files changed
tree: d908109c6e08acd4d03f5d293e75379bd4056a1f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.