Google Git
Sign in
chromium / chromium / src / 3c4e2f3a8ac4971544112280d490015fc073d976
commit3c4e2f3a8ac4971544112280d490015fc073d976[log] [tgz]
authorMario Sanchez Prada <mario@igalia.com>Fri Feb 12 11:12:50 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 12 11:12:50 2021
tree950ad3e4d809b4da7cf4a482e77f8f56e9607181
parent7850a418e5090cfdc0831a4c3f1112d9db58a7df [diff]
Fix flaky tests now that media-related messages were migrated to mojo

Since recent migrations of MediaPlayerDelegate legacy IPC messages to
mojo, we no longer have frame-related messages sharing the same channel
than those media-related messages, meaning that the order is no longer
guaranteed to always happen in the same order when mixing media-related
and frame-related messages.

This caused some flakiness in the EnterPictureInPictureForPausedPlayer
test from the test suites MediaSessionPictureInPictureContentBrowserTest
and PictureInPictureContentBrowserTest, which relied on such order. To
fix the flakiness let's add a small waiting loop that will make sure
the test only advances once the expected change of state happens.

Bug: 1176242, 1176069
Change-Id: Ia2c75d998f554c570a2e8dd116d56a5d0f71c659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2687602
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#853469}
1 file changed
tree: 950ad3e4d809b4da7cf4a482e77f8f56e9607181
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.