android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnUnhandledKeyEventTest.java - chromium/src - Git at Google

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

 package org.chromium.android_webview.test;

 import android.support.test.filters.SmallTest;
 import android.view.KeyEvent;

 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;

 import org.chromium.base.test.util.CallbackHelper;
 import org.chromium.base.test.util.DisabledTest;
 import org.chromium.base.test.util.Feature;
 import org.chromium.content_public.browser.ImeAdapter;
 import org.chromium.content_public.browser.test.util.TestThreadUtils;

 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;

 /**
  * Tests for the WebViewClient.onUnhandledKeyEvent() method.
  */
 @RunWith(AwJUnit4ClassRunner.class)
 public class AwContentsClientOnUnhandledKeyEventTest {
     @Rule
     public AwActivityTestRule mActivityTestRule = new AwActivityTestRule();

     private KeyEventTestAwContentsClient mContentsClient;
     private AwTestContainerView mTestContainerView;

     private static class UnhandledKeyEventHelper extends CallbackHelper {
         private final List<KeyEvent> mUnhandledKeyEventList = new ArrayList<>();

         public List<KeyEvent> getUnhandledKeyEventList() {
             return mUnhandledKeyEventList;
         }

         public void clearUnhandledKeyEventList() {
             mUnhandledKeyEventList.clear();
         }

         public void onUnhandledKeyEvent(KeyEvent event) {
             mUnhandledKeyEventList.add(event);
             notifyCalled();
         }
     }

     UnhandledKeyEventHelper mHelper;

     private class KeyEventTestAwContentsClient extends TestAwContentsClient {
         @Override
         public void onUnhandledKeyEvent(KeyEvent event) {
             mHelper.onUnhandledKeyEvent(event);
             super.onUnhandledKeyEvent(event);
         }
     }

     @Before
     public void setUp() throws Exception {
         mContentsClient = new KeyEventTestAwContentsClient();
         mHelper = new UnhandledKeyEventHelper();
         mTestContainerView = mActivityTestRule.createAwTestContainerViewOnMainSync(mContentsClient);
     }

     /*
     @SmallTest
     @Feature({"AndroidWebView", "TextInput"})
      * http://crbug.com/538377
      * Chromium WebView currently sends unhandled events for all KeyUps and
      * composition codes (and always has), even when the textbox is handling
      * the corresponding KeyDowns.  This behavior violates Android's
      * InputEventConsistencyVerifier, although there are no currently known
      * broken use cases.  The correct fix for this is still unclear, but I'm
      * adding this new test as @DisabledTest to provide a tool for further
      * work.
     */
     @Test
     @DisabledTest
     public void testTextboxConsumesKeyEvents() throws Throwable {
         AwActivityTestRule.enableJavaScriptOnUiThread(mTestContainerView.getAwContents());
         final String data = "<html><head></head><body><textarea id='textarea0'></textarea></body>"
                 + "</html>";
         mActivityTestRule.loadDataSync(mTestContainerView.getAwContents(),
                 mContentsClient.getOnPageFinishedHelper(), data, "text/html", false);
         mActivityTestRule.executeJavaScriptAndWaitForResult(mTestContainerView.getAwContents(),
                 mContentsClient, "document.getElementById('textarea0').select();");

         int callCount;

         callCount = mHelper.getCallCount();
         dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_A);

         dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_DEL);

         // COMPOSITION_KEY is synthetically created for DOM's onkeydown() event while composing
         // text. We don't want to propagate it to WebViewClient.
         dispatchDownAndUpKeyEvents(ImeAdapter.COMPOSITION_KEY_CODE);

         // Alt-left should be unhandled but none of the previous events should be.
         dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_ALT_LEFT);

         mHelper.waitForCallback(callCount, 2);
         assertUnhandledDownAndUp(KeyEvent.KEYCODE_ALT_LEFT);
     }

     @Test
     @SmallTest
     @Feature({"AndroidWebView", "TextInput"})
     public void testUnconsumedKeyEvents() throws Throwable {
         final String data = "<html><head></head><body>Plain page</body>"
                 + "</html>";
         mActivityTestRule.loadDataSync(mTestContainerView.getAwContents(),
                 mContentsClient.getOnPageFinishedHelper(), data, "text/html", false);

         int callCount;

         callCount = mHelper.getCallCount();
         dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_A);
         mHelper.waitForCallback(callCount, 2);
         assertUnhandledDownAndUp(KeyEvent.KEYCODE_A);

         callCount = mHelper.getCallCount();
         dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_DEL);
         mHelper.waitForCallback(callCount, 2);
         assertUnhandledDownAndUp(KeyEvent.KEYCODE_DEL);

         callCount = mHelper.getCallCount();
         dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_ALT_LEFT);
         mHelper.waitForCallback(callCount, 2);
         assertUnhandledDownAndUp(KeyEvent.KEYCODE_ALT_LEFT);
     }

     private boolean dispatchKeyEvent(final KeyEvent event) throws Throwable {
         return TestThreadUtils.runOnUiThreadBlocking(
                 () -> mTestContainerView.dispatchKeyEvent(event));
     }

     private void dispatchDownAndUpKeyEvents(final int code) throws Throwable {
         dispatchKeyEvent(new KeyEvent(KeyEvent.ACTION_DOWN, code));
         dispatchKeyEvent(new KeyEvent(KeyEvent.ACTION_UP, code));
     }

     private void assertUnhandledDownAndUp(final int code) throws Throwable {
         List<KeyEvent> list = mHelper.getUnhandledKeyEventList();
         Assert.assertEquals(
                 "KeyEvent list: " + Arrays.deepToString(list.toArray()), 2, list.size());
         Assert.assertEquals(KeyEvent.ACTION_DOWN, list.get(0).getAction());
         Assert.assertEquals(code, list.get(0).getKeyCode());
         Assert.assertEquals(KeyEvent.ACTION_UP, list.get(1).getAction());
         Assert.assertEquals(code, list.get(1).getKeyCode());

         mHelper.clearUnhandledKeyEventList();
     }
 }
	// Copyright 2016 The Chromium Authors. All rights reserved.
	// Use of this source code is governed by a BSD-style license that can be
	// found in the LICENSE file.

	package org.chromium.android_webview.test;

	import android.support.test.filters.SmallTest;
	import android.view.KeyEvent;

	import org.junit.Assert;
	import org.junit.Before;
	import org.junit.Rule;
	import org.junit.Test;
	import org.junit.runner.RunWith;

	import org.chromium.base.test.util.CallbackHelper;
	import org.chromium.base.test.util.DisabledTest;
	import org.chromium.base.test.util.Feature;
	import org.chromium.content_public.browser.ImeAdapter;
	import org.chromium.content_public.browser.test.util.TestThreadUtils;

	import java.util.ArrayList;
	import java.util.Arrays;
	import java.util.List;

	/**
	* Tests for the WebViewClient.onUnhandledKeyEvent() method.
	*/
	@RunWith(AwJUnit4ClassRunner.class)
	public class AwContentsClientOnUnhandledKeyEventTest {
	@Rule
	public AwActivityTestRule mActivityTestRule = new AwActivityTestRule();

	private KeyEventTestAwContentsClient mContentsClient;
	private AwTestContainerView mTestContainerView;

	private static class UnhandledKeyEventHelper extends CallbackHelper {
	private final List<KeyEvent> mUnhandledKeyEventList = new ArrayList<>();

	public List<KeyEvent> getUnhandledKeyEventList() {
	return mUnhandledKeyEventList;
	}

	public void clearUnhandledKeyEventList() {
	mUnhandledKeyEventList.clear();
	}

	public void onUnhandledKeyEvent(KeyEvent event) {
	mUnhandledKeyEventList.add(event);
	notifyCalled();
	}
	}

	UnhandledKeyEventHelper mHelper;

	private class KeyEventTestAwContentsClient extends TestAwContentsClient {
	@Override
	public void onUnhandledKeyEvent(KeyEvent event) {
	mHelper.onUnhandledKeyEvent(event);
	super.onUnhandledKeyEvent(event);
	}
	}

	@Before
	public void setUp() throws Exception {
	mContentsClient = new KeyEventTestAwContentsClient();
	mHelper = new UnhandledKeyEventHelper();
	mTestContainerView = mActivityTestRule.createAwTestContainerViewOnMainSync(mContentsClient);
	}

	/*
	@SmallTest
	@Feature({"AndroidWebView", "TextInput"})
	* http://crbug.com/538377
	* Chromium WebView currently sends unhandled events for all KeyUps and
	* composition codes (and always has), even when the textbox is handling
	* the corresponding KeyDowns. This behavior violates Android's
	* InputEventConsistencyVerifier, although there are no currently known
	* broken use cases. The correct fix for this is still unclear, but I'm
	* adding this new test as @DisabledTest to provide a tool for further
	* work.
	*/
	@Test
	@DisabledTest
	public void testTextboxConsumesKeyEvents() throws Throwable {
	AwActivityTestRule.enableJavaScriptOnUiThread(mTestContainerView.getAwContents());
	final String data = "<html><head></head><body><textarea id='textarea0'></textarea></body>"
	+ "</html>";
	mActivityTestRule.loadDataSync(mTestContainerView.getAwContents(),
	mContentsClient.getOnPageFinishedHelper(), data, "text/html", false);
	mActivityTestRule.executeJavaScriptAndWaitForResult(mTestContainerView.getAwContents(),
	mContentsClient, "document.getElementById('textarea0').select();");

	int callCount;

	callCount = mHelper.getCallCount();
	dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_A);

	dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_DEL);

	// COMPOSITION_KEY is synthetically created for DOM's onkeydown() event while composing
	// text. We don't want to propagate it to WebViewClient.
	dispatchDownAndUpKeyEvents(ImeAdapter.COMPOSITION_KEY_CODE);

	// Alt-left should be unhandled but none of the previous events should be.
	dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_ALT_LEFT);

	mHelper.waitForCallback(callCount, 2);
	assertUnhandledDownAndUp(KeyEvent.KEYCODE_ALT_LEFT);
	}

	@Test
	@SmallTest
	@Feature({"AndroidWebView", "TextInput"})
	public void testUnconsumedKeyEvents() throws Throwable {
	final String data = "<html><head></head><body>Plain page</body>"
	+ "</html>";
	mActivityTestRule.loadDataSync(mTestContainerView.getAwContents(),
	mContentsClient.getOnPageFinishedHelper(), data, "text/html", false);

	int callCount;

	callCount = mHelper.getCallCount();
	dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_A);
	mHelper.waitForCallback(callCount, 2);
	assertUnhandledDownAndUp(KeyEvent.KEYCODE_A);

	callCount = mHelper.getCallCount();
	dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_DEL);
	mHelper.waitForCallback(callCount, 2);
	assertUnhandledDownAndUp(KeyEvent.KEYCODE_DEL);

	callCount = mHelper.getCallCount();
	dispatchDownAndUpKeyEvents(KeyEvent.KEYCODE_ALT_LEFT);
	mHelper.waitForCallback(callCount, 2);
	assertUnhandledDownAndUp(KeyEvent.KEYCODE_ALT_LEFT);
	}

	private boolean dispatchKeyEvent(final KeyEvent event) throws Throwable {
	return TestThreadUtils.runOnUiThreadBlocking(
	() -> mTestContainerView.dispatchKeyEvent(event));
	}

	private void dispatchDownAndUpKeyEvents(final int code) throws Throwable {
	dispatchKeyEvent(new KeyEvent(KeyEvent.ACTION_DOWN, code));
	dispatchKeyEvent(new KeyEvent(KeyEvent.ACTION_UP, code));
	}

	private void assertUnhandledDownAndUp(final int code) throws Throwable {
	List<KeyEvent> list = mHelper.getUnhandledKeyEventList();
	Assert.assertEquals(
	"KeyEvent list: " + Arrays.deepToString(list.toArray()), 2, list.size());
	Assert.assertEquals(KeyEvent.ACTION_DOWN, list.get(0).getAction());
	Assert.assertEquals(code, list.get(0).getKeyCode());
	Assert.assertEquals(KeyEvent.ACTION_UP, list.get(1).getAction());
	Assert.assertEquals(code, list.get(1).getKeyCode());

	mHelper.clearUnhandledKeyEventList();
	}
	}