commit | 40f742b90554fb75744a896eabf627fcdc657de5 | [log] [tgz] |
---|---|---|
author | Peter Kasting <pkasting@chromium.org> | Wed Jan 16 02:07:38 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 16 02:07:38 2019 |
tree | 0eab938cd099a9f281802640f72a521ca1a1042c | |
parent | 9eb19884ede27f7080c79b9ea596d48bcdd96bf3 [diff] |
Update contrast ratio on the IconLabelBubbleView separator. This was originally written in https://codereview.chromium.org/1998493002/ to implement the spec at https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XZjJURlVaN1hUTzQ . The spec produced contrast ratios for the separator of 2.44 in normal and 3.69 in incognito. Over time the behavior diverged, primarily since the incognito omnibox background color changed. The current omnibox ratio is 7.39. The new code produces ratios of 2.42 in normal and 3.11 in incognito, similar to the original behavior, but bringing incognito closer to normal (presuming that the old normal behavior was the "gold standard" design-wise). The primary motivation here, though, was to unify handling of light and dark so the code didn't "toggle", but simply behaved consistently for all inputs. Bug: 659451 Change-Id: Ic33c506e46864389bed8285f5cfbf439915b5222 Reviewed-on: https://chromium-review.googlesource.com/c/1411926 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#623030}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .