commit | 41093c0de48270ae68cdcbbd616c4fa6c94bdba7 | [log] [tgz] |
---|---|---|
author | Antoine Labour <piman@chromium.org> | Wed Nov 07 23:16:16 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 07 23:16:16 2018 |
tree | 2c2f0324b93ceaea52b2127d14d9012679fb5ff9 | |
parent | c3b89701de8d8e35d6a11c1e8a04f6b45c52097e [diff] |
Fix texture_target_exception_list for unit tests Previously, InProcessGpuThreadHolder initialized texture_target_exception_list according to the production expectations, in particular assuming native GMB types when available. However all unit tests use viz::TestGpuMemoryBufferManager (if any GMBManager at all) which only produces shared memory GMBs. This means the wrong target will be used for those. It's mostly harmless on Mac (GL_TEXTURE_RECTANGLE_ARB) but no so much on other platforms (GL_TEXTURE_EXTERNAL_OES which doesn't allow glTex*Image*). Instead, leave texture_target_exception_list empty, individual tests can initialize it if they need (e.g. if they use a GpuMemoryBufferFactory). Bug: 897214 Change-Id: I55984ef49797fa97f00e2bda35b60a4e6ba734bc Reviewed-on: https://chromium-review.googlesource.com/c/1322610 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606195}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .