Google Git
Sign in
chromium / chromium / src / 41e3c57070c2
commit41e3c57070c2c1ad1aed15c4b0be89a8df4083f7[log] [tgz]
authorMatt Menke <mmenke@chromium.org>Fri Jul 27 19:05:47 2018
committerCommit Bot <commit-bot@chromium.org>Fri Jul 27 19:05:47 2018
tree9812f89196025430fc8674ca3c993c7fdd79884c
parent0fba4dc907589bf2425c43d7e036fc9088a12d8c [diff]
NetworkContext: Always create the CookieStore and ChannelIDStore

This CL makes NetworkContexts create CookieStores and ChannelIDStores in
the hybrid URLRequestContext creation path, where the embedder starts
configuring a URLRequestContextBuilder, and the NetworkContext finishes
configuring it.

The reduces redundant code, lets us test the new path in production
before we ship the network service, and will allow Isolated App
URLRequestContexts to need less code when they're updated to use the
hybrid configuration path (Which I plan to do in a followup CL).

The NetworkContext constructor that takes an already-initialized
URLRequestContext is not modified in this CL.

Bug: 789644
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ibf40ae6497e7be06b0a666bc664ea943e145cae9
Reviewed-on: https://chromium-review.googlesource.com/1152083
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578740}
8 files changed
tree: 9812f89196025430fc8674ca3c993c7fdd79884c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .