Google Git
Sign in
chromium / chromium / src / 42f06e96b2b61b432136007c24a989146bb152c9
commit42f06e96b2b61b432136007c24a989146bb152c9[log] [tgz]
authorIan Barkley-Yeung <iby@chromium.org>Fri Dec 14 03:00:41 2018
committerCommit Bot <commit-bot@chromium.org>Fri Dec 14 03:00:41 2018
tree04f2b8faac070cdcbc6f9141a9dd8f525e07de74
parent4a696c0c1c9c067cf321b795a488b28a2aafe1b4 [diff]
Add Uninstall UI for Crostini Apps

Add UI to handle the "uninstall" menu option when right-clicking on a
Crostini app. This change brings up a confirmation dialog; if the user
confirms, it starts up the container and sends an uninstall message.

UI mocks https://docs.google.com/presentation/d/1akjEdjidRcMH54SK9zMmQVIPaPkwVuatXuKZLJKUqzA/edit

Several known bugs:
 * chromium:909071
 * chromium:909063
 * chromium:898295
so this is behind a flag (CrostiniAppUninstallGui)

BUG=chromium:822514
TEST=Uninstalled multiple applications. Uninstalled applications at the same time for
queuing. Closed notifications while applications were uninstalling or queued. Installed
and uninstalled applications at the same time.

Change-Id: If5bb80cb867e55c3f082c40f89357f05db151985
Reviewed-on: https://chromium-review.googlesource.com/c/1275292
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616567}
27 files changed
tree: 04f2b8faac070cdcbc6f9141a9dd8f525e07de74
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .