commit | 440970797950c37c4cfe7b34e3879ad4f561466c | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Mon Mar 18 09:05:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 18 09:05:23 2019 |
tree | d34fc98665a9732c1ea33d8f6bd53ee80dd5ae59 | |
parent | bc3bd6456fd16d2d81103f5a1695f620a56e804f [diff] |
[Mfill Android] Make accessory state webcontents-scoped Showing the keyboard everywhere (with https://crrev.com/c/1503574) has uncovered inconsistent showing of passwords. This CL tries to mitigate that by moving all state into a separate data store and ensuring, cached data is available whenever the shown WebContents change. Prevents: (rare issues or issues in follow-up CL) * Duplicate key icons * Redundant null checks for unitialized/destroyed states. Both are now an empty state - no inconsistent states should be possible. * missing suggestions when tabs change Minor fix: * circumvent destructor NullPtrException by using NonNull.equals(Nullable) instead of Nullable.equals(NonNull) Bug: 932124 Change-Id: Ia73ea2ca2fdb57c077c45279d1e64577f3a84fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517672 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#641535}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .