commit | 45069649beb282937d45f84d2845c607ef19157c | [log] [tgz] |
---|---|---|
author | Stephane Zermatten <szermatt@chromium.org> | Mon Jan 14 08:55:56 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 14 08:55:56 2019 |
tree | d7d56460273b399f2819cbf6f52c3d431784e009 | |
parent | 3617998bf3ec453e01b2183f9dfe9f3286ccaea8 [diff] |
[Autofill Assistant] Only run interrupts once per WaitForDom. Before this patch, the same interrupt would be run in a WaitForDom as long as its precondition match. This turned out to be difficult to work with in the common case where the interrupt clicks on a button to dismiss the element in the precondition: if we check the preconditions again right away after clicking, the effect of the click would not have time to apply and the interrupt would be run immediately afterwards. The current workaround is to define interrupts to only run once, but what if the interrupt was meant to dismiss a dialog that can appear more than once? With this patch, the same interrupt is run only once in a WaitForDom, but it can still be run multiple times in a script. This way, we avoid the case described above and can reuse interrupt that dismiss. Bug: 806868 Change-Id: I10c59b8c8b4d9cd5be1c0874694595e9dc3ff518 Reviewed-on: https://chromium-review.googlesource.com/c/1406971 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#622398}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .