Google Git
Sign in
chromium / chromium / src / 467337b0e504b5964b163a1a050465324aab8209
commit467337b0e504b5964b163a1a050465324aab8209[log] [tgz]
authorEugene But <eugenebut@google.com>Wed May 22 22:44:44 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 22 22:44:44 2019
treea5de9f8b32906886508911b281a6928e83de9cf5
parent7896c959294e6675f936591cf6591592da8d346a [diff]
Ensure that ChromeEarlGreyUIImpl reports correct line number on failure.

This is done by replacing EarlGrey object with [self earlGrey].
[self earlGrey] is provided by a superclass and returns EarlGreyImpl
object created with correct line number and filename (taken from the
place of ChromeEarlGreyUI macro instantiation).

References to ChromeEarlGreyUI were replaced with self to avoid
recreating ChromeEarlGreyUIImpl object with incorrect line number.

Bug: 963613
Change-Id: Ie1d56a77b080f0ce1efb81ac7240fb3610cebbd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617891
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662388}
3 files changed
tree: a5de9f8b32906886508911b281a6928e83de9cf5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .