tree f4028ae865397719d1e6fce1cfd33071d6c70536
parent 3e34b190866767a53598230f4a2668ec45b1bdfa
author Jun Choi <hongjunchoi@chromium.org> 1542211938 +0000
committer Commit Bot <commit-bot@chromium.org> 1542211938 +0000

Remove callbacks bound to base::Unretained(this) in FidoBleDevice

Replace callbacks in FidoBleDevice bound to base::Unretained(this) to
callbacks bound to weak pointers. When user navigates away from the site
calling the WebAuthN API while request is being dispatched, callbacks in
FidoBleDevice may be invoked after FidoBleDevice is destroyed. This is
especially the case when the user navigates away during pairing process.
In this case, FidoBleDevice::OnReadControlPointLength() will be called
after FidoBleDevice is destroyed.

Bug: 877344
Change-Id: I14ad94cfc9624c50eeee88feb1a12a6f8488c696
Reviewed-on: https://chromium-review.googlesource.com/c/1335727
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607999}