tree 79a5e4b2d98d8081256e4081b2593b917ba658a9
parent 6ff500e4687d65d7cdcecd54193ac611258c360d
author Nick Diego Yamane <nickdiego@igalia.com> 1629997664 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1629997664 +0000

ozone/wayland: Introduce SerialTracker class

Serial tracking has been done in a simple way, which has been sufficient
so far. Though recently we started observing subtle issues that point
out that it must be improved and made more robust [1][2][3]. Simpler
(but less scalable) solutions started to be employed [4], though a
better and more generic approach is needed.

This CL introduces wl::SerialTracker as well as related structs/enums,
which encapsulates logic for keeping track and retrieving serial values
and metadata. It is basically a generalization of serial related code in
WaylandConnection, with an enhanced way of storing/retrieving them in a
categorized way, based on events for which each serial is associated to,
thus allowing to avoid issues such as the ones linked below.

R=msisov@igalia.com, tonikitoo@igalia.com

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1209269
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=1175083
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=1202986
[4] https://chromium-review.googlesource.com/c/chromium/src/+/2854638

Bug: 1211874
Test: ozone_unittests --gtest_filter='WaylandSerialTrackerTest.*'
Change-Id: I5ee9cfa5104f7bad3ec1f9c5943e4027eabeb812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3122285
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/main@{#915622}