Remove the kAllExceptLegacyWindowsPlatform Blink feature
This feature was introduced in https://crrev.com/c/3777546 when Chromium
still supported "legacy" (i.e. < 10) Windows platforms.
Since https://crrev.com/c/4127097, we do not need to worry about legacy
Windows releases and kAllExceptLegacyWindowsPlatform should always be
true.
Change-Id: I453a6621532082bccf59ff474e8e1900863df78e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179881
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Commit-Queue: Raphael Kubo da Costa <kubo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Raphael Kubo da Costa <kubo@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1407762}
diff --git a/components/embedder_support/user_agent_utils.cc b/components/embedder_support/user_agent_utils.cc
index 384a829d..133db93 100644
--- a/components/embedder_support/user_agent_utils.cc
+++ b/components/embedder_support/user_agent_utils.cc
@@ -175,8 +175,7 @@
#else
return ShouldReduceUserAgentMinorVersion(user_agent_reduction) &&
base::FeatureList::IsEnabled(
- blink::features::kReduceUserAgentPlatformOsCpu) &&
- blink::features::kAllExceptLegacyWindowsPlatform.Get();
+ blink::features::kReduceUserAgentPlatformOsCpu);
#endif
}
diff --git a/components/embedder_support/user_agent_utils_unittest.cc b/components/embedder_support/user_agent_utils_unittest.cc
index c4cc77b..179a307 100644
--- a/components/embedder_support/user_agent_utils_unittest.cc
+++ b/components/embedder_support/user_agent_utils_unittest.cc
@@ -578,21 +578,6 @@
version_info::GetMajorVersionNumber().c_str()),
GetUserAgent());
}
-
- // Verify disable reduce legacy windows platform
- scoped_feature_list.Reset();
- scoped_feature_list.InitWithFeaturesAndParameters(
- {{blink::features::kReduceUserAgentMinorVersion, {}},
- {blink::features::kReduceUserAgentPlatformOsCpu,
- {{"all_except_legacy_windows_platform", "true"},
- {"legacy_windows_platform", "false"}}}},
- {});
- {
- EXPECT_EQ(base::StringPrintf(kDesktop,
- version_info::GetMajorVersionNumber().c_str()),
- GetUserAgent());
- }
-
#endif
// Verify only reduce platform and oscpu in desktop user agent string in
diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc
index 6a0c6339..12247f1d 100644
--- a/third_party/blink/common/features.cc
+++ b/third_party/blink/common/features.cc
@@ -2188,12 +2188,6 @@
"build_version",
"0");
-BASE_FEATURE_PARAM(bool,
- kAllExceptLegacyWindowsPlatform,
- &kReduceUserAgentPlatformOsCpu,
- "all_except_legacy_windows_platform",
- true);
-
// Whether `blink::MemoryCache` and `blink::ResourceFetcher` release their
// strong references to resources on memory pressure.
BASE_FEATURE(kReleaseResourceStrongReferencesOnMemoryPressure,
diff --git a/third_party/blink/public/common/features.h b/third_party/blink/public/common/features.h
index d3535c8..40a5a4d 100644
--- a/third_party/blink/public/common/features.h
+++ b/third_party/blink/public/common/features.h
@@ -1431,9 +1431,6 @@
kUserAgentFrozenBuildVersion);
// Parameters for kReduceUserAgentPlatformOsCpu;
-BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE_PARAM(bool,
- kAllExceptLegacyWindowsPlatform);
-
BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(kReducedReferrerGranularity);
BLINK_COMMON_EXPORT BASE_DECLARE_FEATURE(
