Google Git
Sign in
chromium / chromium / src / 4961fe3ac6b8b42767e5ec30fbeced1d84829ef9
commit4961fe3ac6b8b42767e5ec30fbeced1d84829ef9[log] [tgz]
authorNancy Wang <nancylingwang@chromium.org>Fri Oct 21 09:35:04 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 21 09:35:04 2022
treecd7b8c0d08bb87111c47131445ef6158d2c60488
parent4bfb58585ac07951d75a84c4378f11d93dd56b4e [diff]
Fix the website metrics usage time when the tab is closed.

When the tab is closed, SetTabInActivated is called to calculate the
usage time in the past 5 minutes. However, the usage time is not added
to running_time_in_two_hours. SaveUsageTime is responsible for
writing the 5 minutes time to running_time_in_two_hours. Well, if
SaveUsageTime is not called by OnFiveMinutes, when OnTwoHours is called,
running_time_in_two_hours is recorded. Since the tab is closed,
url_info_ is updated to record the opened tabs usage time only, then
the closed tab usage time is lost.

Modify SetTabInActivated to add the usage time in the past 5 minutes to
running_time_in_two_hours for the closed tabs.

BUG=1377175

Change-Id: I7cf651e380ef7ce9587d1096054b6b21972b4e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3970018
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1062015}
1 file changed
tree: cd7b8c0d08bb87111c47131445ef6158d2c60488
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.