Google Git
Sign in
chromium / chromium / src / 4967af02dfd7a1612caf425ad6ad1242805a9b70
commit4967af02dfd7a1612caf425ad6ad1242805a9b70[log] [tgz]
authorAvi Drissman <avi@chromium.org>Wed Feb 20 03:00:29 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 20 03:00:29 2019
treef2cab5b69c723be8e3c2dbab7afd20b559905a41
parent994763a50dce6bbddb3a7a9ad4e76efe03f25a9d [diff]
Don't attempt to clone NSPasteboards.

It doesn't work, as any file promises will be called in, and the
loop over all the flavors will not be equipped to handle it.

The MacViews code wants to provide an OSExchangeDataProvider for
drags that it didn't initiate, so wrap a provider around the
pasteboard rather than clone it.

This is a third attempt to land this (previously attempted
with e11a5a297736acdbc93609906facd5da04e7b6c0 and with
7b01a37f8c4b5fb80e084bd1174d12bf39fec3a6). This version fixes
extension drags.

BUG=908349, 928684, 932051

Change-Id: Ie144ddf78c7e95f6946bbbe77bbda7027914761d
Reviewed-on: https://chromium-review.googlesource.com/c/1476239
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633531}
6 files changed
tree: f2cab5b69c723be8e3c2dbab7afd20b559905a41
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .