tree c47adc8a9a8e4d9c550fb9756ba852414ee17ae3
parent 659c8284c33baf483121f1248d5aaa989d5dabe0
author yukishiino <yukishiino@chromium.org> 1493283679 -0700
committer Commit bot <commit-bot@chromium.org> 1493283679 +0000

Revert of binding: Changes the association among global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance (2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96e30a1dee9dd2

This CL reverts the following CL, too.
v8binding: Makes ToV8(window) work without a frame.
https://codereview.chromium.org/2713623002/

Original issue's description:
> v8binding: Makes ToV8(window) work without a frame.
>
> Makes DOMWindow hold a WindowProxyManager and makes
> it possible that ToV8(window) work without a frame.
>
> With this CL, all tests in
> external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects.html
> pass without a failure.
>
> This CL is a preparation for
> https://crrev.com/2693893007
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2713623002
> Cr-Commit-Position: refs/heads/master@{#464907}
> Committed: https://chromium.googlesource.com/chromium/src/+/58af3664facba6332528fd983988d51cf3636af4

BUG=712638,713676,713667,715150

Review-Url: https://codereview.chromium.org/2848503002
Cr-Commit-Position: refs/heads/master@{#467623}