Google Git
Sign in
chromium / chromium / src / 4e1204029dc933d06749c83fa4cbd3841871a812
commit4e1204029dc933d06749c83fa4cbd3841871a812[log] [tgz]
authorSami Kyostila <skyostil@chromium.org>Wed Feb 06 15:56:17 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 06 15:56:17 2019
tree37f330a80b8f1d5cecf53aad019cec1a59ef58a1
parent4ef26c53d578241e6f6ae9d2b1370f60ba9fb278 [diff]
android: Deal with child process termination before launch has concluded

If BrowserChildProcessHostImpl is deleted before a pending child process
launch has finished, child process disconnection can be notified without
a valid process id for the child process. This patch changes the child
exit observer to deal with this case. By code inspection both clients of
this class (AwBrowserTerminator, ChildProcessCrashObserver) can already
deal with notifications without a valid process id.

Bug: 863341
Change-Id: I4237b1df68072263916e31dd23684519b6810bd4
Reviewed-on: https://chromium-review.googlesource.com/c/1455944
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629587}
2 files changed
tree: 37f330a80b8f1d5cecf53aad019cec1a59ef58a1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .