Google Git
Sign in
chromium / chromium / src / 4ea68d6281778c6034ac8af120a04c3e46bcdf2f
commit4ea68d6281778c6034ac8af120a04c3e46bcdf2f[log] [tgz]
authorwutao <wutao@chromium.org>Thu Feb 28 05:26:51 2019
committerCommit Bot <commit-bot@chromium.org>Thu Feb 28 05:26:51 2019
tree7572d5dc0fc90dcfa404abc3360a68f4059118ed
parent7a865534479c11e290d8737cbf21f774567f04b0 [diff]
app_list: Not close embedded Assistant UI when open Launcher

When Hotword is detected, it will show Assistant UI in Launcher.
However, we call CloseAssistantUi which will interrupt with the voice
interaction therefore the mic will be closed. This patch limits the
condition that only close ui if not in kLauncherEmbeddedUi.
We also need to correct the app list state when close the embedded ui,
which is required because the app list state is global.

Bug: 924624
Test: manual
Change-Id: I9d5bfc3dbdfa504f06dca2fdde6163a3c46beebe
Reviewed-on: https://chromium-review.googlesource.com/c/1487794
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636328}
1 file changed
tree: 7572d5dc0fc90dcfa404abc3360a68f4059118ed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .