tree 9883223878498c04c2ec52e52921b5557e16e494
parent ee0b79bfc0b440a27492743754511e6d48b3fac1
author Roland Bock <rbock@google.com> 1623240214 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1623240214 +0000

Refactor DeviceManagementService unit tests for more coverage

The unit tests for DeviceManagementService use TestURLLoaderFactory
to intercept and analyse the requests made by the
DeviceManagementService. But they use

service_->OnURLLoaderCompleteInternal(
        service_->GetSimpleURLLoaderForTesting(), ...);

to simulate the answers from the DMServer.
This is relying on implementation details and it is bypassing
DeviceManagementService::OnURLLoaderComplete

This CL uses the TestURLLoaderFactory to simulate DMServer replies
instead. It fixes a few incorrect expectations in the tests, too, and it
will make future strucural changes in the DeviceManagementService
easier.

Bug: 1217037
Change-Id: Idb0755427025c7ced64197493590219f6840d0a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940806
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890711}