tree 09c9e08539f8dd420c175cde506cc231e43f40fe
parent 1fa3981d86535dfddfab2fc89ded02b5610b847f
author Lowell Manners <lowell@chromium.org> 1547635779 +0000
committer Commit Bot <commit-bot@chromium.org> 1547635779 +0000

Make secondary account sync tests share a single TestURLLoaderFactory.

Before this change, these tests had multiple TestURLLoaderFactory
instances. One, which is declared in SyncTest, plus an additional
instance each time BuildFakeGaiaCookieManagerServiceWithOptions was
invoked.

Eventually, FakeGCMS will be eliminated entirely in these tests. This
change separates out one of the logical side effects of eliminating
FakeGCMS, which that there will be a single TestURLLoaderFactory
instance.

We are splitting out this change to be able to verify whether the switch
to a single shared factory was the cause of the flake in
https://chromium-review.googlesource.com/c/chromium/src/+/1396148. Our
suspicion is that the flake was rather caused by the fact that in that
CL, the TestURLLoaderFactory was *not* used by the main profile, whereas
prior to that CL FakeGCMS instances had been installed for all Profiles.

Assuming that this change sticks, we will follow it up by hiding the
usage of |test_url_loader_factory_| inside a new SecondarySyncTest
class, thus eliminating the passing of the raw pointer.

This is part of step 1a of the plan to eliminate FakeGCMS entirely:
TBR=rkaplow@chromium.org

https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit
Change-Id: I86837090af84e94bdd9887ac9ee5e9c96bbef8da
Bug: 907782
Reviewed-on: https://chromium-review.googlesource.com/c/1411877
Commit-Queue: Lowell Manners <lowell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623188}