commit | 500f6b1d3d667d47550b8de91ebcb411ae1dcda8 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Thu Jan 24 11:19:50 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 24 11:19:50 2019 |
tree | d8fe2aa574c9a59e4bf015d82273cdceb6fc71a3 | |
parent | 7eb6d44457143d7fc314b3bb112b3316aceb17d0 [diff] |
Remove potential hang+timeout from _nocompile tests If output buffers got full while running the tests, the script would hang, polling the process forever and it would never return a return_code from proc.poll(). This might have caused some random timouts but if so, it is unclear what 64 KB output filled up the buffers, unless the buffers were smaller than local testing would indicate. This stores stdout and stderr in temporary files and reads those files back into memory after the process has finished. Bug: 882852 Change-Id: I4e6ace2bb783fadcde3f43643ccad03c58ef519a Reviewed-on: https://chromium-review.googlesource.com/c/1425736 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625603}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .