Google Git
Sign in
chromium / chromium / src / 503f03ba2cd69a9dd21142b27f6051f5ff40774d
commit503f03ba2cd69a9dd21142b27f6051f5ff40774d[log] [tgz]
authorDelan Azabani <dazabani@igalia.com>Mon Jan 30 12:32:02 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 30 12:32:02 2023
tree47c724a3d829e4864c254026e589661af7fe80ed
parent48c4dbe67501dceb9c6d2feca77ee1b2cb2338f4 [diff]
HighlightInheritance: fix spelling/grammar feature checks

CL:3780430 makes ::spelling-error and ::grammar-error behave as if
HighlightInheritance is always on (like ::highlight), but there are
still two call sites that check for the feature naïvely.

This patch fixes DetermineValidPropertyFilter and the invalidation in
LayoutObject::SetStyle accordingly.

Bug: 1024156
Change-Id: Ieff0a29ae9e83161a8840db137cf229023fd1d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4199621
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1098541}
2 files changed
tree: 47c724a3d829e4864c254026e589661af7fe80ed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.