Google Git
Sign in
chromium / chromium / src / 5120c7e4466c232c0d035d88ff9e75eb90ae4e3a
commit5120c7e4466c232c0d035d88ff9e75eb90ae4e3a[log] [tgz]
authorPeter Kasting <pkasting@chromium.org>Mon Jan 07 22:18:46 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 07 22:18:46 2019
treef55ce1bae8b26f108690906ae2b1307aa8b1fe3e
parenta11fc96ade7c321ea2dac3bd9331652278e3291a [diff]
BrowserView should not report that guest mode is incognito.

The existing comment in the code noted this is probably incorrect and suggested
auditing the callers.  In looking at the callers, it looks like they all care
about this for the purpos of "what color/resource ID should be used for the
window".  Since guest windows should appear like normal windows and not OTR
windows (AFAIK), I believe the callers all want this change.

Bug: none
Change-Id: I51b2d776d71a0cec296de04a8304762a32ba4b7e
Reviewed-on: https://chromium-review.googlesource.com/c/1396957
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620501}
1 file changed
tree: f55ce1bae8b26f108690906ae2b1307aa8b1fe3e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .