commit | 5137a913a4bb38b35ecc1a6b1163f90322cd00f1 | [log] [tgz] |
---|---|---|
author | yoshiki iguchi <yoshiki@chromium.org> | Tue Apr 09 06:36:00 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 09 06:36:00 2019 |
tree | 843de075392fb0ae9b0003b7963e2a321b78336e | |
parent | 94afe7f4d5f26702e60b9cabdd55b9ed9743c7cd [diff] |
Call SlideOutController.Delegate.OnSlideChanged at the right timing Previously, OnSlideChanged was not called when the notification went back to the origin position after the animation ends, but when the animation starts. So we had the detection code in SlideHelper.Update() and there was a bug of no control buttons (crr crbug.com/949436). This CL refactors the CL and makes it called at the correct timing (just after animation is finished) and the correct |in_progress| status. Also this CL adds some tests of SlideOutController. Bug: 949436 Test: manual (did the steps on the bug, and observed as expected) Change-Id: I0fdc7b6173ef2ad415ce981b482b65f319b948d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552209 Reviewed-by: Tim Song <tengs@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#649021}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .