commit | 52964c260bee1e96f746517215ac398ccd2c67ba | [log] [tgz] |
---|---|---|
author | Esmael El-Moslimany <aee@chromium.org> | Fri Dec 07 01:11:05 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 07 01:11:05 2018 |
tree | 6e31c645bf4854d49e8676713634a057dd976544 | |
parent | dc08cacbde1ee26cbe43bbf576097dd9528467f2 [diff] |
WebUI: cr-slider, simplify slider logic by removing |updateValueInstantly| property |updateValueInstantly| is only used by the display size slider. The property was passed through settings-slider. This CL moves the |updateValueInstantly| logic to settings-slider. The reasoning is that cr-slider had a property |value| that represents the slider value unless the slider was in a dragging state and |updateValueInstantly| was false. A new value called |immediateValue_| was added to always have the correct value even during drag. But this was only to ultimately stop a value-changed event from being handled which would update |pref.value|. Instead of having two properties in cr-slider and one property in settings-slider to store the slider value, moving the |updateValueInstantly| logic to settings-slider significantly simplifies the code. Bug: 902873 Change-Id: I5d5d8771aa8246850bfd9b4926d820180e43c211 Reviewed-on: https://chromium-review.googlesource.com/c/1363642 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#614530}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .