tree 7d7baabfd2d14b0329c5360dea15bd50cabe2310
parent c90da078f23d29eb450c7a94824d6f658fbb3cee
author haraken <haraken@chromium.org> 1415667820 -0800
committer Commit bot <commit-bot@chromium.org> 1415667853 +0000

Pending tasks in a message loop should be deleted before shutting down Blink

Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.)

To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink.

BUG=411026
TEST=None. I cannot reproduce the crash.

Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf
Cr-Commit-Position: refs/heads/master@{#296697}

Committed: https://crrev.com/16d32a9f7f6d1ebb639cacedb5156272a9fec764
Cr-Commit-Position: refs/heads/master@{#297338}

Review URL: https://codereview.chromium.org/583043005

Cr-Commit-Position: refs/heads/master@{#303557}