Google Git
Sign in
chromium / chromium / src / 543f73d8c9bd279b3715b18f553ca1dc4516bd87
commit543f73d8c9bd279b3715b18f553ca1dc4516bd87[log] [tgz]
authorDmitry Gozman <dgozman@chromium.org>Thu Apr 25 02:06:05 2019
committerCommit Bot <commit-bot@chromium.org>Thu Apr 25 02:06:05 2019
tree4fa1ee7b8893d8cf630a60473252b11858656691
parentab37cc08360c4d3e332c7a09c62223b4f20fffc7 [diff]
Disable navigation during DidStartProvisionalLoad

Navigation initiated during DidStartProvisionalLoad may cancel
current provisional document loader or even replace it with a new one.
This confuses FrameLoader and could mistakenly start loading the
wrong document loader (e.g. a placeholder one).

One example would be UserMediaClientImpl::ReadyToCommitNavigation
triggering MediaStreamTrack::onended event and running JS which can
initiate navigation.

Bug: 954796
Change-Id: I1fd2a9639ecff26fe3c0e0c1a001101ab00b4304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577795
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653854}
1 file changed
tree: 4fa1ee7b8893d8cf630a60473252b11858656691
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .