commit | 5547a44212b6188feeb823af535a62ce5f5f9364 | [log] [tgz] |
---|---|---|
author | Jay Harris <harrisjay@chromium.org> | Mon Jun 17 00:52:13 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 17 00:52:13 2019 |
tree | 74a9734aac62813557953e763b0d0bb3cba73d0d | |
parent | 9cd583d139d0485636ae69da48d2f9f4244d0824 [diff] |
Fixes a bug where popups were opened at the wrong size on OSX This was caused because we weren't taking the title bar height into account in BrowserNonClientFrameViewMac::GetWindowBoundsForClientBounds. The fix is to explicitly add the titlebar size (which will be zero when a custom titlebar is drawn) and GetTopInsets() to the client bounds when converting them to window bounds. This CL fixes a similar to https://chromium-review.googlesource.com/c/chromium/src/+/1626909 Bug: 967935, 834908 Change-Id: I9fb6e537a86dc2babb567fdac14774787f0c5d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657868 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#669553}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .