commit | 563659ccbc3bb19c0797e55f0652a5109e579d9d | [log] [tgz] |
---|---|---|
author | Nektarios Paisios <nektar@chromium.org> | Thu Oct 25 17:12:01 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 25 17:12:01 2018 |
tree | ba2ffe1ab2eef1159e934fe65fa8981a4e5dee6f | |
parent | afe65cf118cec7824601a6699ada9ebed62b0992 [diff] |
Revert "Accessibility shouldn't skip continuations in layout tree" This reverts commit 99bfce414a10e56ed93b8baef6d9d13651596c1c. Reason for revert: Broke NVDA and Jaws access to several pages, including the Google's corp homepage. Original change's description: > Accessibility shouldn't skip continuations in layout tree > > Code to walk the layout tree for accessibility had a subtle bug > when encountering continuations, resulting in strange corner > cases where content could be completely missing from the > accessibility tree. > > This patch switches to a new, simpler algorithm to walk the > layout tree for accessibility. It's simpler to explain and > requires less code. > > All existing tests pass, included are three new > regression tests demonstrating cases that failed previously, > plus another simple test illustrating the importance of > handling continuations correctly. > > Bug: 834653 > > Change-Id: I0704e79c94332862065e2976b90de61697f7f83f > Reviewed-on: https://chromium-review.googlesource.com/c/1292870 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602051} TBR=dmazzoni@chromium.org,szager@chromium.org,aboxhall@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834653 Change-Id: I3d2bcf5300006394880c0c95221b8dea3276ca4a Reviewed-on: https://chromium-review.googlesource.com/c/1299435 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#602767}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .