commit | 573f46751824b8dcfbec675291eacc8c581ae441 | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Tue Dec 11 22:50:40 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 11 22:50:40 2018 |
tree | b527aea9fe020b66dd6d3be4982b18c824705008 | |
parent | fdacb825658504dcd1879f6a530361b7f2880ab0 [diff] |
Remove code to store the last popup transiently in WebFrameWidgetImpl This code was copied over from WebViewImpl when adding the HidePopups call in order to have a pinch zoom or scroll tap outside the current popup in a non-main-frame-local-rooted iframe hide the current popup. This is modifying state on WebViewImpl meant to track between TapDown and Tap, to avoid the Tap showing a popup that was hidden by TapDown. WebFrameWidgetImpl does not show popups on Tap, and if it did, it should track this transient state locally not on WebViewImpl. Also remove the undocumented FALLTHROUGH which was not explained in 671732 as it now goes to nothing. R=dcheng@chromium.org Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db Bug: 912193, 671732 Reviewed-on: https://chromium-review.googlesource.com/c/1372539 Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615708}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .