commit | 5763956c51145c6ef6c71898809e7e70fc328433 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Mon Apr 01 15:07:02 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Apr 01 15:07:02 2019 |
tree | 35bbc29c965691d38f68d9c1393b2a161c819151 | |
parent | 8c79f4df8517671d5821927572a425786d428e96 [diff] |
Correct builds deps for the mojo types in services/network Some types in services/network causes generated code elsewhere to include a file in services/network/public/cpp:cpp_base. To make this permissible by gn check --check-generated, make the deps to services/network/public/cpp:cpp_base a public dep. An example of the kind of error this fixes: ERROR at //out/Default/gen/services/content/public/mojom/navigable_contents.mojom-test-utils.cc:33:11: Can't include this header from here. #include "services/network/public/cpp/net_ipc_param_traits.h" ^------------------------------------------------- The target: //services/content/public/mojom:mojom is including a file from the target: //services/network/public/cpp:cpp_base It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //services/content/public/mojom:mojom --> //services/network/public/mojom:websocket_mojom --[private]--> //services/network/public/cpp:cpp_base Bug: 938893 Change-Id: I6446eea5b0fb6aeb03d24d0dc771c4f65e02002c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538410 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#646314}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .