commit 57acc6849210749fb73a1fde614609d64f1799f4
author Mark Pearson <mpearson@chromium.org> Fri Oct 10 20:32:13 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 10 20:32:13 2025
tree 57b0e0e22534ce03b9afa24b4012a0bfebe78684
parent 2e952a77cb0206336ec6e1b3d6752bf68d14839d

Revert "Add split view to new tab button context menu"

This reverts commit 629461e9d788c475f946dfd7d2e1beede0dbae2f.

Reason for revert:

New tests consistently fail on linux64-rel-ready:
https://ci.chromium.org/ui/p/chrome/builders/ci/linux64-rel-ready

Example:
https://ci.chromium.org/ui/p/chrome/builders/ci/linux64-rel-ready/56773/overview

TabStripTabGroupMenuMoreEntryPointsEnabled.NewTabButtonContextMenuSplitView:
interactive_test_internal.cc(266): Failed
Interactive test failed on step 7 (EnsurePresent( ElementIdentifier NewTabButtonMenuModel::kNewSplitView )) with reason kElementNotVisibleAtStartOfStep; step type kShown; id ElementIdentifier NewTabButtonMenuModel::kNewSplitView
UI Elements
  ╰─[CURRENT CONTEXT] [ACTIVE] Tabbed browser window, 1 tab(s) (active: 0) profile Default at x:10-1060 y:10-790 (1050x780)
     ├─Pivot element (part of test automation)
     ├─[ACTIVE] Widget "BrowserWidget" at x:10-1060 y:10-790 (1050x780)
     │  ╰─BrowserView - kBrowserViewElementId at x:14-1056 y:10-786 (1042x776)
     │     ├─TopContainerView - kTopContainerElementId at x:14-1056 y:10-97 (1042x87)
     │     │  ├─TabStripRegionView - kTabStripRegionElementId at x:14-960 y:10-51 (946x41)
     │     │  │  ├─TabSearchContainer - kTabSearchContainerElementId at x:20-48 y:10-51 (28x41)
     │     │  │  │  ╰─TabSearchButton - kTabSearchButtonElementId at x:20-48 y:10-51 (28x...

TabStripTabGroupMenuMoreEntryPointsEnabled.NewTabButtonContextMenuSplitViewDisabled:
[ RUN      ] TabStripTabGroupMenuMoreEntryPointsEnabled.NewTabButtonContextMenuSplitViewDisabled
[110633:110633:1010/123719.714320:INFO:components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc:206] No machine level policy manager exists.
[110665:110665:1010/123719.811682:WARNING:ui/gfx/linux/gpu_memory_buffer_support_x11.cc:49] dri3 extension not supported.
[110665:110665:1010/123719.814195:WARNING:sandbox/policy/linux/sandbox_linux.cc:404] InitializeSandbox() called with multiple threads in process gpu-process.
[110633:110633:1010/123719.885051:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.Properties.GetAll: object_path= /org/freedesktop/UPower/devices/DisplayDevice: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[110633:110633:1010/123719.885077:WARNING:dbus/property.cc:174] GetAll request failed for: org.freedesktop.UPower.Device
[110633:110633:1010/123719.910937:WARNING:ui/base/idle/idle_linux.cc:98] None of the known D-Bus ScreenSaver services could be used.
[110633:110633:1010/123719.940692:FATAL:chrome/browser/ui/views/frame/browser_view.cc:3544] Check failed: multi_contents_view_. 
#0 0x59b062a02eb2 base::debug::CollectStackTrace() [../../base/debug/stack_trace_posix.cc:1052:7]
#1 0x59b0629ef5be base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:279:20]
#2 0x59b062936d73 logging::LogMessage::Flush() [../../base/logging.cc:705:29]
#3 0x59b062936c3d logging::LogMessage::~LogMessage() [../../base/logging.cc:694:3]
#4 0x59b062923df2 logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() [../../base/check.cc:164:3]
#5 0x59b062923adb logging::CheckNoreturnError::~CheckNoreturnError() [../../base/check.cc:321:16]
#6 0x59b061c8aa39 BrowserView::OnSplitTabChanged() [../../chrome/browser/ui/views/frame/browser_view.cc:3544:3]

TabStripTabGroupMenuMoreEntryPointsEnabled.VerifyNewTabButtonContextMenu:
interactive_test_internal.cc(266): Failed
Interactive test failed on step 8 (EnsurePresent( ElementIdentifier NewTabButtonMenuModel::kNewSplitView )) with reason kElementNotVisibleAtStartOfStep; step type kShown; id ElementIdentifier NewTabButtonMenuModel::kNewSplitView
UI Elements
  ╰─[CURRENT CONTEXT] [ACTIVE] Tabbed browser window, 1 tab(s) (active: 0) profile Default at x:10-1060 y:10-790 (1050x780)
     ├─Pivot element (part of test automation)
     ├─[ACTIVE] Widget "BrowserWidget" at x:10-1060 y:10-790 (1050x780)
     │  ╰─BrowserView - kBrowserViewElementId at x:14-1056 y:10-786 (1042x776)
     │     ├─TopContainerView - kTopContainerElementId at x:14-1056 y:10-97 (1042x87)
     │     │  ├─TabStripRegionView - kTabStripRegionElementId at x:14-960 y:10-51 (946x41)
     │     │  │  ├─TabSearchContainer - kTabSearchContainerElementId at x:20-48 y:10-51 (28x41)
     │     │  │  │  ╰─TabSearchButton - kTabSearchButtonElementId at x:20-48 y:10-51 (28x...



Original change's description:
> Add split view to new tab button context menu
>
> This adds another option to the new tab button context menu. It will
> make a split view with the current active tab, and the new split will
> be on the new tab page.
>
> Bug: 450398347
> Change-Id: I04dcf3b5d6d4a1577be781520d78af9780f5008c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7024472
> Reviewed-by: Eshwar Stalin <estalin@chromium.org>
> Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
> Reviewed-by: Alison Gale <agale@chromium.org>
> Commit-Queue: Dominic Austria <dominicaustria@google.com>
> Cr-Commit-Position: refs/heads/main@{#1528279}

Bug: 450398347
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I4aa77757dd114255a79170c31cf306d582ae5b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032586
Auto-Submit: Mark Pearson <mpearson@chromium.org>
Owners-Override: Mark Pearson <mpearson@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1528337}