commit | 57d8bde6a48a121cbf7dc91c08b4c4a8ffaf712c | [log] [tgz] |
---|---|---|
author | Robert Liao <robliao@chromium.org> | Fri Mar 08 20:24:16 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 08 20:24:16 2019 |
tree | 0b224a71c214bc8900f4affa64f51e91f0609f4e | |
parent | f9b5b24b6475e5a5bdd400890141a44973672fdf [diff] |
Revert "Reland "Show controls and update time indicators during seeking""" This reverts commit 1db377b6c045dbc07f59fd8c6cb9fe99b08b6609. Reason for revert: Implicated in causing webkit_layout_tests virtual/video-surface-layer/media/controls-drag-timebar-rendering.html to fail. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/47047 Original change's description: > Reland "Show controls and update time indicators during seeking"" > > This commit relands f57001bcc79c30f2acc3be7bc47aee5e60bab10e. > > > Show controls and update time indicators during seeking > > > > This commit modifies the MediaControls to show the controls and update > > the current time indicators (current time text + timeline thumb) > > immediately during seek requests so the element behavior during rapid > > seek requests (e.g. user is holding down the FF button on their BT > > keyboard) look similar to when a user is scrubbing the timeline with > > their mouse. > > > > Bug: 748749 > > > > TEST=MediaControlsImplTest, manual testing > > out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest* > > > > Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d > > Reviewed-on: https://chromium-review.googlesource.com/c/1274945 > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#636493} > > This commit was reverted due to causing a layout test to be flaky. > > Additional testing: > python third_party/blink/tools/run_web_tests.py --seed 4 > -t Release --repeat 30 media/controls-drag-timebar-rendering.html > (same for virtual/video-surface-layer/media/... as well) > > Updated controls-drag-timebar-rendering.html with an attempt to > maintain the purpose of the test while updating it to allow the video > to render the first couple frames in the 'actual' case. > > Bug: 937029 > Change-Id: I4908d638800854ce6503e7629b3a0bd070aeadfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506534 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639072} TBR=mlamouri@chromium.org,steimel@chromium.org,agdoug@amazon.com Change-Id: Ieb91587129d32eee749ad719f4c89a70e3936abb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511826 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#639144}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .