commit 59c19d8e9f26e2ec065e56d188432be131f6cb4f
author jdoerrie <jdoerrie@chromium.org> Tue Feb 12 00:39:19 2019
committer Commit Bot <commit-bot@chromium.org> Tue Feb 12 00:39:19 2019
tree 066b8ec012fe11ba0096fddadac95c90bb62fb25
parent d755a8cf625f40b2b2a4c7e96adb8337b135aa68

[Passwords] Add Field Trial Testing Config for HTTP FOAS Experiment

This change adds a Field Trial Testing Configuration for the Fill On
Account Select over HTTP Experiment.

Bug: 914765
Change-Id: I4271c3c4c5cdec403e52815a077f384de7042957
Reviewed-on: https://chromium-review.googlesource.com/c/1463445
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631012}

chrome/browser/password_manager/password_manager_browsertest.cc

diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 8081368..7236ae87 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -2268,15 +2268,22 @@
   std::string username_field;
   std::string password_field;
 
-  // Verify username has been autofilled
   ASSERT_TRUE(content::ExecuteScriptWithoutUserGestureAndExtractString(
       RenderFrameHost(), "sendMessage('get_username');", &username_field));
-  EXPECT_EQ("temp", username_field);
 
-  // Verify password has been autofilled
   ASSERT_TRUE(content::ExecuteScriptWithoutUserGestureAndExtractString(
       RenderFrameHost(), "sendMessage('get_password');", &password_field));
-  EXPECT_EQ("pa55w0rd", password_field);
+
+  // Verify username and password have only been autofilled if FOAS on HTTP is
+  // not active.
+  if (base::FeatureList::IsEnabled(
+          password_manager::features::kFillOnAccountSelectHttp)) {
+    EXPECT_TRUE(username_field.empty());
+    EXPECT_TRUE(password_field.empty());
+  } else {
+    EXPECT_EQ("temp", username_field);
+    EXPECT_EQ("pa55w0rd", password_field);
+  }
 }
 
 // Check that a username and password are not filled in forms in iframes

testing/variations/fieldtrial_testing_config.json

diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
index 3ee6f21..3c0af49 100644
--- a/testing/variations/fieldtrial_testing_config.json
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -3345,6 +3345,26 @@
             ]
         }
     ],
+    "PasswordFillOnAccountSelectOverHttp": [
+        {
+            "platforms": [
+                "android",
+                "chromeos",
+                "ios",
+                "linux",
+                "mac",
+                "windows"
+            ],
+            "experiments": [
+                {
+                    "name": "Enabled",
+                    "enable_features": [
+                        "FillOnAccountSelectHttp"
+                    ]
+                }
+            ]
+        }
+    ],
     "PasswordGenerationRequirements": [
         {
             "platforms": [