Google Git
Sign in
chromium / chromium / src / 5ae83bc362f969fe2262bffe7e78a513868903ff
commit5ae83bc362f969fe2262bffe7e78a513868903ff[log] [tgz]
authorJulian Pastarmov <pastarmovj@chromium.org>Fri Feb 15 15:14:04 2019
committerCommit Bot <commit-bot@chromium.org>Fri Feb 15 15:14:04 2019
treecb8e74ac5f7433f0d5c921feb5e5775d4b8c1b77
parente7add99a7150ff2a2fd203ec84e2335c523c8312 [diff]
Make the PolicyPathParser more reliable on MacOS.

The ${machine_name} variable would sporadically fail to resolve on try
bots. This change make it revert to "localhost" if the actual host name
can not be resolved. This behavior will be also better for customers
rather than leaving the possibly invalid path containing ${machine_name}
verbatim.

BUG=327520
TEST=PolicyPathParserTests.AllPlatformVariables not flaking anymore

Change-Id: I9b931e301ac73703aa7fe7cb7a623daa112ae8c3
Reviewed-on: https://chromium-review.googlesource.com/c/1475490
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632618}
2 files changed
tree: cb8e74ac5f7433f0d5c921feb5e5775d4b8c1b77
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .