commit | 5be06c0804fa5cbf2a87de870a84a711c0d82baa | [log] [tgz] |
---|---|---|
author | Ria Jiang <riajiang@chromium.org> | Wed Sep 13 15:22:25 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 13 15:22:25 2017 |
tree | c1683a7b1e2e55d577dbff4aff553aca50b7bc3e | |
parent | a2dc3e7214f2d70c23ece4dd908b48e33bed15a0 [diff] |
Drop the event when the target window has been deleted. In the viz-hit-test case, when we cannot find the target window in EventTargeter, we were using NOTREACHED before this CL. But there are cases where the target window has simply been deleted by the time this event is processed, e.g. clicking the settings button inside system tray's network page, mouse move events after that but before the system tray goes away would fail. In these cases, it makes sense to just drop the event like we did in non-viz hit-test. Kept the TODO to investigate if it can be a security fault when no target window is found. Also fixes a memory exception in HTQ when using the transform directly. Bug: 752380 Change-Id: Ifa099c88a98d623b8be363fe3a77b7bc8eea4a54 Reviewed-on: https://chromium-review.googlesource.com/651564 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#501636}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .