commit | 5be95125dc971bd30eb0e074b46549532ef0318b | [log] [tgz] |
---|---|---|
author | Yi Gu <yigu@chromium.org> | Fri Jul 06 22:35:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 06 22:35:36 2018 |
tree | d1166ad698110ed111981159bceef371c1ccc5bf | |
parent | 2f752b9d88d2faa826e68f93d352e22f4463389f [diff] |
[cc] Reorder impl side keyframe model add / remove logic Currently we push new keyframe models on impl followed by removing any completed ones. This is to make sure that we don't push the keyframe models twice because if we do it the other way around, a finished main thread keyframe model will push itself to impl if its impl side counterpart got removed prior to the push. Actually, for finished keyframe models there is no need to copy them over to impl as we remove them right after the push. Besides, adding new keyframe models then removing them violates the principle that a keyframe effect should have only one keyframe model per property. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50dc93c5c358b0d1711a3d5561a96ccd46698a3b Bug: 860341 Reviewed-on: https://chromium-review.googlesource.com/1127451 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Ali Juma <ajuma@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#573095}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .