commit 5c24af4f7b9897f494c2a63525c2b953862a779e
author Dana Fried <dfried@chromium.org> Tue Apr 23 16:54:46 2019
committer Commit Bot <commit-bot@chromium.org> Tue Apr 23 16:54:46 2019
tree 55f347bfc4edde33221065bfdd126f0917fede45
parent 69121d5cbc6fbcd27e35389da3dcb47aaea1fb2e

Change ImageSkia::DeepCopy() to return an instance.

Since ImageSkia is a value type which wraps a refcounted pointer, there
is no reason to have a smart pointer to an ImageSkia. This removes the
only remaining instance in the ImageSkia API which returns a unique_ptr
rather than an instance.

There is an open question of how to pass ImageSkia in general:
 1. instance (preserving value semantics but incurring the cost of
    AddRef and ReleaseRef)
 2. const reference (losing value semantics but avoiding refcount
    changes)

Right now we're going with (1) but I am willing to switch to (2) - I'm
not deeply committed to either.

Bug: 953845
Change-Id: Ie8b0a4b6720742d61e39413bd98e03256e234a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562757
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653223}