commit | 5cad6ce0e5c50259fc5d69d87e844444b980268f | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Thu Feb 14 11:13:34 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Feb 14 11:13:34 2019 |
tree | 690ebeeb535a0d071df39c8b6234147a68288256 | |
parent | 2f0047bd75275a20f851e443fbe573741d7734ee [diff] |
Too many switches namespaces (jumbo win compile fix) The existance of both a top level ::switches and sub namespace switches bite again. Inside accessibility code if you just say "switches" you will resolve to accessibility::switches if the compiler knows that namespace exists. In jumbo builds the compiler knows that so this code broke. The full fix is to either rename the top level |switches| or all the sub namespace |switches| and that is a messy change (though it would bring the code closer to style guide conformance). Same with the |features| namespace. The fix here is to make the namespace fully qualified by adding a :: prefix. TBR=kbabbitt@microsoft.com,sky@chromium.org Bug: 928811 Change-Id: Ic593a97c1ef653c9e2df411d84ad0dd9d19c2c89 Reviewed-on: https://chromium-review.googlesource.com/c/1472670 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#632163}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .