commit | 5cfae77d4b1b26f67e63f65dcd75cdd77c0dc733 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Mar 26 18:14:09 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 26 18:14:09 2019 |
tree | 1a019f260052b57a065954858e6804e33cd2383f | |
parent | 1938b7a5771f8488df7ce5deeba355ededcf9256 [diff] |
Fixing build dependency for the MailboxHolder type MailboxHolder uses and exposes gpu/ipc/common/mailbox_holder_struct_traits.h so it needs to be a public dependency (as it already is in mailbox_holder_for_blink.typemap). One example of many resulting dependency errors: ERROR at //out/Default/gen/device/vr/public/mojom/isolated_xr_service.mojom-test-utils.cc:29:11: Can't include this header from here. ^-------------------------------------------- The target: //device/vr/public/mojom:mojom is including a file from the target: //gpu/ipc/common:struct_traits It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //device/vr/public/mojom:mojom --> //gpu/ipc/common:interfaces --[private]--> //gpu/ipc/common:struct_traits Bug: 938893 Change-Id: I598db331d43cff5212d7d739da96e0648552b7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535859 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644424}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .