tree 6ffde298a50b5753ceae11bdcc4bbc0af5c6965f
parent 2ecc3e0b5052d5ac21e0924f5b3dcf628d1c7357
author Florian Leimgruber <fleimgruber@google.com> 1683207852 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1683207852 +0000

Remove origin from AutofillProfile constructor.

The concept of origins is about to be removed from AutofillProfile
entirely. See doc linked in the bug. As a first step, this CL removes
the origin parameter from AutofillProfile's constructor.

In Autofill, the exact value of the origin doesn't matter (anymore). It
is only distinguished between settings and non-settings origin. For this
reason, almost-all non-settings origins are dropped. Settings origins
are kept by an explicit AutofillProfile::set_origin() call.
In a few locations, such as when reading from the database and when
converting between proto <-> AutofillProfile, the values of the origin
are intentionally kept.

Lastly, this CL simplifies some of the constructor calls, since the
default constructor of AutofillProfile already generates a random GUID.

This CL keeps the behavior as-is.

Most of this CL was generated using tools/git/mffr.py and regex like the
following:
Pattern: 'AutofillProfile (\w+)\((\n.*)?base::Uuid::GenerateRandomV4\(\).AsLowercaseString\(\),( |\n.*)kSettingsOrigin\)'
Replacement: 'AutofillProfile \1;\1.set_origin(kSettingsOrigin)'

Bug: 1441905
Change-Id: I3869bf682d95230c62b8316a89a423269b4055ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4497758
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139485}