commit | 612d357c2b8cacb6b2d80809b1167f22bbe3c774 | [log] [tgz] |
---|---|---|
author | Alexis Hetu <sugoi@google.com> | Fri Feb 22 21:54:31 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 21:54:31 2019 |
tree | ba853942fb5f4c04747326638be5664592e6838d | |
parent | 0cce9e79536830a404c869d39be37875b3520bfc [diff] |
Y and UV planes release mechanism fix The Y and UV planes weren't getting released properly because the local variables used in base::RetainBlock() are snapshots of their current values and do not get updated by subsequent code. In this case, y_surface and uv_surface would always be at their original value of EGL_NO_SURFACE and eglReleaseTexImage/eglDestroySurface would never get called. Using pointers to these values solves the issue, since the pointers do not get modified by subsequent code and the values can be checked properly by dereferencing the pointers. Bug: chromium:932986 chromium:929088 Change-Id: Id0b9fcc79af733b645eaf8fed12d905dd40e9fbc Reviewed-on: https://chromium-review.googlesource.com/c/1483690 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634837}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .