Google Git
Sign in
chromium / chromium / src / 630f1690aac12a8a96b9e4edccae8718834c3a68
commit630f1690aac12a8a96b9e4edccae8718834c3a68[log] [tgz]
authorEugene But <eugenebut@google.com>Tue Dec 11 02:11:07 2018
committerCommit Bot <commit-bot@chromium.org>Tue Dec 11 02:11:07 2018
tree4f6fa28c49150c6523c364acf9f6833bd45eea37
parent8eed09b1ff9a59c6cc6e0386aa40dddffdcefe3a [diff]
Fix external file presentation.

This bug is a regression, because ios/web started presenting error pages
if hasControllerForURL: returns NO and the URL is not a WebUI URL.
ios/web change was a reasonable change, but BVC did not follow API
contract and returned NO from hasControllerForURL: even if controller
existed.

Return YES from hasControllerForURL: for kChromeUIExternalFileHost if
NativeController actually exists. This change enforces existing API
constract for CRWNativeContentProvider.

EG tests do not have good infrastructure to write end-to-end test for
external URLs. BVC is also not testable, so this CL does not include
tests.

Bug: 902271
Change-Id: I81c08b439460bcbf81f0e7234f9cdbe57938e6fe
Reviewed-on: https://chromium-review.googlesource.com/c/1370931
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615384}
1 file changed
tree: 4f6fa28c49150c6523c364acf9f6833bd45eea37
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .