tree e447a84ba46fa9cb06c257ad374c9d4f9742d619
parent 4e08f84946416194b3a8e542c3a93da4150d6476
author rbpotter <rbpotter@chromium.org> 1619106508 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1619106508 +0000

WebUI: Make web_ui() non-const

This method is marked as const, but it returns a non-const pointer to
an object that owns the WebUIMessageHandler and therefore can modify or
even delete the handler, if non-const methods are called on it. In
accordance with the guidance at [1], change this method to non-const.

Note: Not adding an additional:
const WebUI* web_ui() const;
method, as a const WebUI* does not seem to be useful; since WebUI is an
interface, all of its methods are non-const, and handlers generally
call this method in order to do something like GetWebContents().

[1] https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/const.md

Bug: None
Change-Id: Ia0a48e84eb36919fe2d027b450cccc25417238ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827427
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875177}