Google Git
Sign in
chromium / chromium / src / 638ab30408cfcd997039160c5ffb126c5a82eff3
commit638ab30408cfcd997039160c5ffb126c5a82eff3[log] [tgz]
authorVictor Costan <pwnall@chromium.org>Sun Oct 21 05:49:39 2018
committerCommit Bot <commit-bot@chromium.org>Sun Oct 21 05:49:39 2018
tree4667a0dabe790440f7a2477f7ef6ce89f40c0a9c
parent557c93c3070e306ea9b685632dddc7c8c8fd8d4b [diff]
AppCache: clean up WeakPtrFactory members in classes with children.

This CL marks AppCache clases with WeakPtrFactory members as final, and
removes WeakPtrFactory members from classes that have subclasses.

The superclasses of AppCache classes with WeakPtrFactory members were
checked for WeakPtrFactory members, resulting in minor cleanups.

This CL does not tackle AppCacheUrlRequestJob, because net:URLRequestJob
(which has a WeakPtrFactory) has 35 subclasses. This case will be
addressed separately.

TBR=kinuko

Change-Id: I04bb0757c34fa03620517d04571cba5a0e4a77a5
Reviewed-on: https://chromium-review.googlesource.com/c/1267337
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601431}
28 files changed
tree: 4667a0dabe790440f7a2477f7ef6ce89f40c0a9c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .