commit | be2073bda20c503d1afd8bc513e7b79300e09838 | [log] [tgz] |
---|---|---|
author | Dmitry Gozman <dgozman@chromium.org> | Mon Oct 29 22:15:46 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 29 22:15:46 2018 |
tree | 07c993c263f4f6f4d3a2e202aed8e6f27363140d | |
parent | e4f6ea1d83094af84b5a8cc90e6f206274ac6b0d [diff] |
[DevTools] Implement mojom::DevToolsAgent for workers 1) Use blink::DevToolsAgent in WorkerInspectorController. This replaces the ad-hoc interface for communicating with worker's debugger with a mojo interface used for frames and shared/service worker's shadow pages. 2) Create WorkerDevToolsAgentHost. This is similar to other agent hosts, keeps itself alive while the corresponding worker is alive, and reuses DevToolsSession machinery for inspection. 3) Report dedicated workers to the browser process when auto attach is on. mojom::DevToolsAgentHost is now notified about child workers and gets their DevToolsAgent interfaces to debug in the future. 4) Add TargetHandler to service/shared/dedicated worker sessions, to handle communication with nested dedicated workers. 5) Retire WorkerInspectorProxy and ExecutionContextWorkerRegistry. These are covered by DevToolsAgent now, which reports to it's host. 6) Retire InspectorWorkerAgent, which is replaced by WorkerDevToolsAgentHost on the browser side. The benefits are: - unified interface for inspecting any entity including workers; - workers now support flatten mode of operations; - all inspection targets are now listed on the browser side and represented with DevToolsAgentHost, which allows for further simplification; - less abstractions - we can even get rid of InspectorSession now. Bug: 775132 Change-Id: Ib4f58677a81ce48d4c2382f05d1166f730a2e2c3 Reviewed-on: https://chromium-review.googlesource.com/c/1183589 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603652}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .