Google Git
Sign in
chromium / chromium / src / 65a85834865ebffd0d2ce8d1b3b5f13cb4016f51
commit65a85834865ebffd0d2ce8d1b3b5f13cb4016f51[log] [tgz]
authorMichael Giuffrida <michaelpg@chromium.org>Thu Feb 22 23:47:53 2018
committerMichael Giuffrida <michaelpg@chromium.org>Thu Feb 22 23:47:53 2018
tree773a4a6d73728419b3e69ad3388b9bd0627c65a1
parent64461531b578e20751309ffabcbe67493c934ced [diff]
WindowActivityWatcher: Verify browser window exists

It's apparently possible for
BrowserList::SetLastActive(Browser* browser) to be called before
|browser| is added to the BrowserList. This might happen, e.g., if a
BrowserView's widget receives an activation event before
CreateBrowserWindow() returns.

This will cause WindowActivityWatcher's CreateMetrics() helper function
to dereference the null pointer at browser->window().

(cherry picked from commit 3c2815cfbf41f0c76d74c64800d6d60c328d3d7b)

Bug: 811243,811191
Change-Id: Ia377a810b73494f88d1cd2b4532367950f35b1f7
Reviewed-on: https://chromium-review.googlesource.com/924353
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537825}
Reviewed-on: https://chromium-review.googlesource.com/932008
Cr-Commit-Position: refs/branch-heads/3325@{#562}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
1 file changed
tree: 773a4a6d73728419b3e69ad3388b9bd0627c65a1
  1. .clang-format
  2. .eslintrc.js
  3. .git-blame-ignore-revs
  4. .gitattributes
  5. .gitignore
  6. .gn
  7. .vpython
  8. AUTHORS
  9. BUILD.gn
  10. CODE_OF_CONDUCT.md
  11. DEPS
  12. ENG_REVIEW_OWNERS
  13. LICENSE
  14. LICENSE.chromium_os
  15. OWNERS
  16. PRESUBMIT.py
  17. PRESUBMIT_test.py
  18. PRESUBMIT_test_mocks.py
  19. README.md
  20. WATCHLISTS
  21. android_webview/
  22. apps/
  23. ash/
  24. base/
  25. blink/
  26. build/
  27. build_overrides/
  28. cc/
  29. chrome/
  30. chrome_elf/
  31. chromecast/
  32. chromeos/
  33. cloud_print/
  34. codereview.settings
  35. components/
  36. content/
  37. courgette/
  38. crypto/
  39. dbus/
  40. device/
  41. docs/
  42. extensions/
  43. gin/
  44. google_apis/
  45. google_update/
  46. gpu/
  47. headless/
  48. infra/
  49. ios/
  50. ipc/
  51. jingle/
  52. mash/
  53. media/
  54. mojo/
  55. native_client_sdk/
  56. net/
  57. pdf/
  58. ppapi/
  59. printing/
  60. remoting/
  61. rlz/
  62. sandbox/
  63. services/
  64. skia/
  65. sql/
  66. storage/
  67. styleguide/
  68. testing/
  69. third_party/
  70. tools/
  71. ui/
  72. url/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .