tree b3b5f1b4d36738681d3bb305c8e49d12baaa91dc
parent 5662f7801ac93e6c0b82b2a4569a2127d3d46ec2
author Sohail Rajdev <sorajdev@microsoft.com> 1724235610 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1724235610 +0000

Allow WebContents with no window in ExtensionInstallPromptShowParams

Earlier, ExtensionInstallPromptShowParams did not allow WebContents
which had no parent window. They were only allowed in tests and this
was ensured by the CHECK_IS_TEST() macro in the constructor.

However, there can be real world cases (outside tests) in which the
WebContents do not have a parent window. One example is
WebstoreInstallWithPrompt that uses dummy WebContents which do not
seem to have a parent window on macOS.

This check relaxes the test-only assumption and allows non-test code
to pass WebContents which do not have an associated parent window.

Bug: 360321351
Change-Id: I0e2e506507e4e126b039f951c1cb4e94f7096efa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5797771
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Sohail Rajdev <sorajdev@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1344684}