)]}' { "commit": "65eaaf4ff757a827e5477b123fd772d7da49b78a", "tree": "43aa83869e112681069df9dd52fbf70132762c43", "parents": [ "e542d68e6a8336c908104b0ecfbaff3a4b071aa2" ], "author": { "name": "Yuichiro Hanada", "email": "yhanada@chromium.org", "time": "Fri Dec 14 07:18:38 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 14 07:18:38 2018" }, "message": "Rename {Get,Set}SelectionRange to {Get,Set}EditableSelectionRange.\n\nSome implementation of TextInputClient interface, for example RWHVA, can\nhave text outside of an editable text field.\nFor those views, {Get, Set}SelectionRange is confusing names because\nit\u0027s not clear whether they return selections outside of the editable\ntext field or not.\nThis CL renames them to {Get, Set}EditableSelectionRange to make it\nclear that they returns only selections in an editable text field.\n\nBug: 901439, 908762\nTest: Build.\nChange-Id: I99e6140a635a61b755ebfa35efff2d306cec8d32\nReviewed-on: https://chromium-review.googlesource.com/c/1373932\nCommit-Queue: Yuichiro Hanada \u003cyhanada@chromium.org\u003e\nReviewed-by: Sadrul Chowdhury \u003csadrul@chromium.org\u003e\nReviewed-by: Mitsuru Oshima (gardener - slow) \u003coshima@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#616605}", "tree_diff": [ { "type": "modify", "old_id": "1142470cd782b73aec92dbe2cdc7737305128461", "old_mode": 33188, "old_path": "chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc", "new_id": "ce72993c8fe64ef1efa4d3b8e59ffb81eb9a0ca5", "new_mode": 33188, "new_path": "chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc" }, { "type": "modify", "old_id": "cae24c76291966e805c031af8e077dae1b590d65", "old_mode": 33188, "old_path": "chrome/browser/chromeos/input_method/textinput_test_helper.cc", "new_id": "b2cfba3c1cac402f9b6ccd1238dda901fa3195e6", "new_mode": 33188, "new_path": "chrome/browser/chromeos/input_method/textinput_test_helper.cc" }, { "type": "modify", "old_id": "5d8845ca3aa956da0ade994a08c24e9bf586e993", "old_mode": 33188, "old_path": "chrome/browser/ui/views/ime_driver/remote_text_input_client.cc", "new_id": "0ff96ed4663fc0827d4f3a443b49723866e2256c", "new_mode": 33188, "new_path": "chrome/browser/ui/views/ime_driver/remote_text_input_client.cc" }, { "type": "modify", "old_id": "157308aff94b4c7e392afe7b8b565b7ae8686fae", "old_mode": 33188, "old_path": "chrome/browser/ui/views/ime_driver/remote_text_input_client.h", "new_id": "6bcd332d208797f75ef708e82aac267e96784c28", "new_mode": 33188, "new_path": "chrome/browser/ui/views/ime_driver/remote_text_input_client.h" }, { "type": "modify", "old_id": "7181aa6cfc06850dadb06b347244dd87ee880182", "old_mode": 33188, "old_path": "components/arc/ime/arc_ime_service.cc", "new_id": "18a58f439a83214226d5ac209fcbc8ae8079939e", "new_mode": 33188, "new_path": "components/arc/ime/arc_ime_service.cc" }, { "type": "modify", "old_id": "695df6ee708ae9b0e2d8008ea8f846598614ee39", "old_mode": 33188, "old_path": "components/arc/ime/arc_ime_service.h", "new_id": "23297e1deac97ca806cf6ee65ce49db5327e53e3", "new_mode": 33188, "new_path": "components/arc/ime/arc_ime_service.h" }, { "type": "modify", "old_id": "549b3725caf804fb02120d27cd46bc535ac7b037", "old_mode": 33188, "old_path": "components/arc/ime/arc_ime_service_unittest.cc", "new_id": "c044f65a7118281bd23ef88c3272142f5d2dc6f9", "new_mode": 33188, "new_path": "components/arc/ime/arc_ime_service_unittest.cc" }, { "type": "modify", "old_id": "ad34380ed6874a1e898ebecae8787aff6e3aebce", "old_mode": 33188, "old_path": "components/exo/text_input.cc", "new_id": "f2534c4c42bdc13255158c48a52337bb7d5d6f40", "new_mode": 33188, "new_path": "components/exo/text_input.cc" }, { "type": "modify", "old_id": "96c6f444aebe639b528067835bccacc5aa01d99b", "old_mode": 33188, "old_path": "components/exo/text_input.h", "new_id": "4a47440954da800c35915683088fa792ced29e2f", "new_mode": 33188, "new_path": "components/exo/text_input.h" }, { "type": "modify", "old_id": "caa00cebf350fad012d54b55e86d9d6aec8a9667", "old_mode": 33188, "old_path": "content/browser/renderer_host/render_widget_host_view_aura.cc", "new_id": "642e95614d6c873cec67bba7abe50dc81e72f860", "new_mode": 33188, "new_path": "content/browser/renderer_host/render_widget_host_view_aura.cc" }, { "type": "modify", "old_id": "e719fb13dda6b946608484f03acdbcf67edb85ba", "old_mode": 33188, "old_path": "content/browser/renderer_host/render_widget_host_view_aura.h", "new_id": "1be2dec6b9bc5aeb882ab3e4b3a770017b6b289a", "new_mode": 33188, "new_path": "content/browser/renderer_host/render_widget_host_view_aura.h" }, { "type": "modify", "old_id": "3d0644ad38996247f9fc9a87a16d9c03fa1d2d44", "old_mode": 33188, "old_path": "content/browser/renderer_host/render_widget_host_view_aura_unittest.cc", "new_id": "76285987609d48b655c5476f3692c30d0161cb7e", "new_mode": 33188, "new_path": "content/browser/renderer_host/render_widget_host_view_aura_unittest.cc" }, { "type": "modify", "old_id": "3299270a52cb41c9e14065b5ca7c221754305fd9", "old_mode": 33188, "old_path": "ui/base/ime/dummy_text_input_client.cc", "new_id": "34dfc79db8e4a93938e4a926151ece584b36b9d8", "new_mode": 33188, "new_path": "ui/base/ime/dummy_text_input_client.cc" }, { "type": "modify", "old_id": "acc72b866e537b04b8ded7cea3babf3b3c58244e", "old_mode": 33188, "old_path": "ui/base/ime/dummy_text_input_client.h", "new_id": "e313b0356db27d102aa28ea3395b64be3dde03b0", "new_mode": 33188, "new_path": "ui/base/ime/dummy_text_input_client.h" }, { "type": "modify", "old_id": "f7343b30c076397c260d89482a7aa3bc5f6916e2", "old_mode": 33188, "old_path": "ui/base/ime/input_method_auralinux.cc", "new_id": "9a793126005cff527e6313be245a8a0c72c042ef", "new_mode": 33188, "new_path": "ui/base/ime/input_method_auralinux.cc" }, { "type": "modify", "old_id": "2496391504e1679f150d6f90f43d9a0690fed4c0", "old_mode": 33188, "old_path": "ui/base/ime/input_method_auralinux_unittest.cc", "new_id": "cc67ef7d7e49e836bd95019250f53ddd2b2ac74b", "new_mode": 33188, "new_path": "ui/base/ime/input_method_auralinux_unittest.cc" }, { "type": "modify", "old_id": "76f14cac5afc243aae349501f4393f11c7c1a557", "old_mode": 33188, "old_path": "ui/base/ime/input_method_base.cc", "new_id": "fc96c61b538ee7589c32db3147bb1f439719ce12", "new_mode": 33188, "new_path": "ui/base/ime/input_method_base.cc" }, { "type": "modify", "old_id": "918bd6eca9a70caa2646c802409f4dbe000d8387", "old_mode": 33188, "old_path": "ui/base/ime/input_method_chromeos.cc", "new_id": "79a9f5a6f72d4d9d7fc13690634f72a87f8ca692", "new_mode": 33188, "new_path": "ui/base/ime/input_method_chromeos.cc" }, { "type": "modify", "old_id": "5b4a72a861f2b86b7b4bc64a2c8e354af456425e", "old_mode": 33188, "old_path": "ui/base/ime/input_method_chromeos_unittest.cc", "new_id": "3ab3975bd2c5a43672860050ee41efafa7c88a9e", "new_mode": 33188, "new_path": "ui/base/ime/input_method_chromeos_unittest.cc" }, { "type": "modify", "old_id": "333607e76eae5b03f207f8b0bd11d8522e1c9859", "old_mode": 33188, "old_path": "ui/base/ime/input_method_win_base.cc", "new_id": "6b7c3bef62aec0027f1c8e1ad9d86e975d0964c2", "new_mode": 33188, "new_path": "ui/base/ime/input_method_win_base.cc" }, { "type": "modify", "old_id": "c475c432dcfa20c0c9f5e61c1aec7cad11014edd", "old_mode": 33188, "old_path": "ui/base/ime/text_input_client.h", "new_id": "4bcaf18c841042aa3a03d3296a4c4d26fabd4650", "new_mode": 33188, "new_path": "ui/base/ime/text_input_client.h" }, { "type": "modify", "old_id": "a65641e1a553140f81fdb85c2ac5341be2467d49", "old_mode": 33188, "old_path": "ui/base/ime/win/tsf_text_store_unittest.cc", "new_id": "ed22f583e4eb5cb3b5185ef5ca2b1d380737f9f5", "new_mode": 33188, "new_path": "ui/base/ime/win/tsf_text_store_unittest.cc" }, { "type": "modify", "old_id": "8f1941096bcbe800ad36111f81d0fc03007b1ed4", "old_mode": 33188, "old_path": "ui/views/cocoa/bridged_native_widget_unittest.mm", "new_id": "5c729fcde948dcfe154bec0ca7d496ea42185d10", "new_mode": 33188, "new_path": "ui/views/cocoa/bridged_native_widget_unittest.mm" }, { "type": "modify", "old_id": "98aab8c61c7f02ce98283f62385eebb61184c5e2", "old_mode": 33188, "old_path": "ui/views/controls/prefix_selector.cc", "new_id": "fe8decc9a68684fd1893d40225c59e812b729456", "new_mode": 33188, "new_path": "ui/views/controls/prefix_selector.cc" }, { "type": "modify", "old_id": "801c9112b73916e7fbe2987f0d25f855c765c508", "old_mode": 33188, "old_path": "ui/views/controls/prefix_selector.h", "new_id": "de9caa39616fef9d41126a7a41ff2767289e91fc", "new_mode": 33188, "new_path": "ui/views/controls/prefix_selector.h" }, { "type": "modify", "old_id": "2ff60335add8f621f06d9c450863585104a191df", "old_mode": 33188, "old_path": "ui/views/controls/textfield/textfield.cc", "new_id": "90968d5c75dc9afd8f2bc30a9b47163ac65e1492", "new_mode": 33188, "new_path": "ui/views/controls/textfield/textfield.cc" }, { "type": "modify", "old_id": "f5d0914d43eb6555765aa4ead62a3f60b6ee418f", "old_mode": 33188, "old_path": "ui/views/controls/textfield/textfield.h", "new_id": "38b565590a642bf61c150fb45702c765619061f1", "new_mode": 33188, "new_path": "ui/views/controls/textfield/textfield.h" }, { "type": "modify", "old_id": "879ebf11a8386efe76536938f8d0dd018753713a", "old_mode": 33188, "old_path": "ui/views/controls/textfield/textfield_unittest.cc", "new_id": "7b3f7fd6c62cfb7643903f3e06ce3029c4f9e54e", "new_mode": 33188, "new_path": "ui/views/controls/textfield/textfield_unittest.cc" }, { "type": "modify", "old_id": "8718925085110951d0bdebd663836d52b87414e0", "old_mode": 33188, "old_path": "ui/views/examples/label_example.cc", "new_id": "e1df4fe5d9c27a3f85f7d22e1824fe8b8dd09e91", "new_mode": 33188, "new_path": "ui/views/examples/label_example.cc" }, { "type": "modify", "old_id": "397425e89055e8bcc900bb6ec34ec04b838e60fd", "old_mode": 33188, "old_path": "ui/views_bridge_mac/bridged_content_view.mm", "new_id": "08f50f84157b37092fea78cb6098fddaf23fec79", "new_mode": 33188, "new_path": "ui/views_bridge_mac/bridged_content_view.mm" } ] }